Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I would suggest, that only fetch the request data, if log is not off.
This way, if log is off, there will be no significant overhead.
Your initial plan with JSON-logs was good, because I could pick the data to compare.
But now, it is better to optional not log the timestamp. With this optional parameter, I can compare the log-file after running the test cases. If they are the same, the integration test is successful.
If you are approve this pull request, I would be very thankful, if you could release a new version, so I can use the new features.
Thanks for your time so far!
Viele Grüße, Simon