Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace npms to official npm registry & fix isOfficial badge in plugin-manager #7021

Merged
merged 2 commits into from
Aug 20, 2022

Conversation

LacazeThomas
Copy link
Contributor

Hi,

First, thank you for this wonderful teminal !

I removed npms registry from the plugins-manager because of a wrong version display.
See issue

I switched to the official npm registry (docs available here).


I also fixed the bool isOfficial which is incorect in both registry.
Example for npms and npm registry there is no publisher.name but publisher.username.

Result :

Capture d’écran 2022-08-20 à 21 50 28

Instead of :

Capture d’écran 2022-08-20 à 21 51 05

@Eugeny Eugeny merged commit 805d457 into Eugeny:master Aug 20, 2022
@Eugeny
Copy link
Owner

Eugeny commented Aug 20, 2022

Thank you so much! @all-contributors please add @LacazeThomas for code

@allcontributors
Copy link
Contributor

@Eugeny

I've put up a pull request to add @LacazeThomas! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants