Attempt to remove busywait in ChannelTx #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PonyPC Could you verify if this PR works for you? |
EpicEric
commented
Dec 4, 2024
| .min(buf.len() as u32) as usize; | ||
| if writable == 0 { | ||
| // TODO fix this busywait | ||
| cx.waker().wake_by_ref(); | ||
| if buf.is_empty() || self.sender.is_closed() { |
There was a problem hiding this comment.
I am not sure if buf.is_empty() should lead to the channel being closed, but maybe the condition above should only be reached when the window_size is zero?
|
Mentioning the #197 PR here as it seems to have a more nuanced approach to the optimal solution. |
|
@EpicEric I've made a very rough attempt at this in #408 (not tested yet) - I'm not very good at low level async and could use a review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some progress on #401. This passes the
poll_mk_msgwaker along with the window size in order to avoid busy-waiting for changes. This is currently untested, hence the draft PR.