Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -cbc ciphers. #297

Merged
merged 6 commits into from
Jun 8, 2024
Merged

Implement -cbc ciphers. #297

merged 6 commits into from
Jun 8, 2024

Conversation

Barre
Copy link
Contributor

@Barre Barre commented Jun 6, 2024

This PR addresses issues related to connecting to legacy Cisco devices with no upgrade path (similar to issue #277).

Changes Introduced

• Refactored cipher/mod.rs: Make room to be able to implement CBC crypto support.
• Updated cipher/block.rs: To provide an interface compatible with both streaming ciphers and CBC.
• General Cipher Updates: Light modifications to other ciphers for compatibility with the new interface.

Context

I had trouble connecting to older Cisco devices which posed challenges due to their outdated cryptographic support.

Copy link
Owner

@Eugeny Eugeny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks great!

russh/src/cipher/block.rs Outdated Show resolved Hide resolved
@Barre Barre requested a review from Eugeny June 8, 2024 09:44
@Eugeny Eugeny merged commit 800969b into Eugeny:main Jun 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants