Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sync failure notification via notify_terminal_error #785

Merged
merged 1 commit into from
Nov 7, 2021
Merged

Add support for sync failure notification via notify_terminal_error #785

merged 1 commit into from
Nov 7, 2021

Conversation

mmrko
Copy link
Contributor

@mmrko mmrko commented Oct 25, 2021

First off, thanks for this amazing tool! 🙏 We've utilized docker-sync extensively across our RoR codebases for a few years now.

Proposing to add support for notify_terminal: 'errors_only' to provide the user a visual cue when docker-sync might have stopped syncing (e.g. after restarting Docker Desktop).

Example:

Screen Shot 2021-10-25 at 15 25 21

...sync container name being sync-login with source directory /Users/make/Documents/login.

@mmrko mmrko requested a review from EugenMayer October 30, 2021 12:39
Copy link
Owner

@EugenMayer EugenMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you a lot for your work!

@EugenMayer EugenMayer merged commit ae2dfdf into EugenMayer:master Nov 7, 2021
@mmrko mmrko deleted the add-notify-terminal-error branch November 24, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants