Fix D4M edge strategy detection #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for version 0.4.6 |
This was referenced Oct 26, 2017
tripox
force-pushed
the
fix_docker_for_mac_detection
branch
from
ffb4bbc
to
302ed28
Compare
|
could you rebase the branch so we do not have merge conflicts? |
17.10.0-ce-mac36
tripox
force-pushed
the
fix_docker_for_mac_detection
branch
from
302ed28
to
48d23ce
Compare
|
looks good already, only the tests and this is a great addition. Thank you for the contribution! |
EugenMayer
changed the title
|
great contribution ,thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the newest version of Docker for Mac edge (17.10.0-ce-mac36),
docker info | grep 'Operating System'outputs:Operating System: Docker for Mac.This results in docker-sync choosing the 'unison' strategy which seems broken.