Fix Material color to check for tiles dynamically instead of using a … #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed id list, updated elementID byte->ushort
|
Question: Does this also "fix" the display of Cobalt and Cobaltite? Thanks |
|
there is nothing to be fixed about those. the internal colours of those elements are just that bright, adjusting those is an optional thing anyone can do but does not belong into this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current live version of the mod uses a static list of building IDs for applying the tile-tint. this doesnt work for any tiles added by other mods and base tiles that arent added to the list like the storage tile.
the change made in this request adjusts this behavior to instead check for a KAnimGridTileVisualizer component, something present on all these tiles to work with all tiles klei or other mods add.
The ElementIdx also changed recently from byte to ushort, allowing mods and klei to add more than 256 elements in total, so I adjusted that aswell