Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to AsciiDoc variant on the main page #1095

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Jun 7, 2022

This commit adds link to AsciiDoc variant on the main page, in order to make it more discoverable.

@klaude
Copy link
Member

klaude commented Jun 7, 2022

Thanks for the patch! The deploy preview is failing because hugo can't build the site, due to missing files.

2:27:37 PM: $ hugo
2:27:37 PM: Building sites … ERROR 2022/06/07 19:27:37 [en] REF_NOT_FOUND: Ref "/version/2/1/code_of_conduct.adoc": "/opt/build/repo/content/_index.md:38:32": page not found
2:27:37 PM: WARN 2022/06/07 19:27:37 found no layout file for "asciidoc" for kind "page": You should create a template file which matches Hugo Layouts Lookup Rules for this combination.
<snip>

Version 2.1 doesn't have an asciidoc variant. Would you be willing to make one and include it in this PR? Thanks!

@vpavic
Copy link
Contributor Author

vpavic commented Jun 8, 2022

Ah, sorry about that - I didn't build the site locally before submitting the PR.

I'll look into adding the missing version soon, thanks for the feedback.

This commit adds link to AsciiDoc variant on the main page, in order to make it more discoverable.
@vpavic
Copy link
Contributor Author

vpavic commented Jun 9, 2022

I've fixed the issue. The problem weren't missing files (AsciiDoc variants are apparently generated dynamically) but rather me referencing .adoc instead of .md in the link. Anyway, the preview is now successfully deployed.

One final thing to consider: I added the link to the AsciiDoc variant as the last one, but my feeling is that Markdown and AsciiDoc variant are probably the most interesting ones to the community and should be the top two in the list.

Copy link
Member

@CoralineAda CoralineAda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@CoralineAda CoralineAda merged commit b6b8445 into EthicalSource:release Jul 6, 2022
@vpavic vpavic deleted the vpavic-patch-1 branch July 6, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants