Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Added npm upgrade in root dockerfile #5582

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Added npm upgrade in root dockerfile #5582

merged 4 commits into from
Mar 31, 2022

Conversation

hanzlamateen
Copy link
Member

Summary

Updated npm to latest version in docker root image. This is to fix transient npm ERR! code ERR_SOCKET_TIMEOUT faced while doing npm i in docker image. Below are the reference to this issue on npm github issue

npm/cli#4553
npm/cli#3078 (comment)

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@barankyle barankyle merged commit 3090cf4 into dev Mar 31, 2022
@barankyle barankyle deleted the npm-upgrade-dockerfile branch March 31, 2022 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants