Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retrieving the cron expression from the config when a config path… #203

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

peterjaap
Copy link

… is set

@peterjaap
Copy link
Author

@fredden any chance of getting this merged?

@fredden
Copy link
Collaborator

fredden commented Dec 27, 2023

Thanks for the nudge. This came in while I was away, and I partially forgot about it upon my return. I'll see if I can find time to test this change this week.

@fredden fredden merged commit da5a94c into Ethan3600:2.x Dec 28, 2023
@fredden
Copy link
Collaborator

fredden commented Dec 28, 2023

Thanks for this. I tested this with catalog_product_alert locally. When config_path and schedule are both unspecified in the XML, the value from the database (via the default/derived config_path) was already being shown.

@peterjaap peterjaap deleted the fix-cron-config-path branch December 28, 2023 09:13
@fredden fredden linked an issue Dec 28, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support config_path for cron expressions
2 participants