Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Correction de dépréciations d'assertions #1138

Merged
merged 1 commit into from
May 21, 2024

Conversation

azmeuk
Copy link
Contributor

@azmeuk azmeuk commented May 21, 2024

assertEquals (avec un s) et assertRegexpMatches sont dépréciés et supprimés dans python 3.12

https://docs.python.org/3.11/library/unittest.html#deprecated-aliases

  • You have read our contribution guidelines.
  • Your PR targets the develop branch.
  • The title of your PR starts with [WIP] or [DONE].

Copy link
Collaborator

@Badatos Badatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo, bien vu !
D'autant qu'assertEquals était déjà déprécié en python 3.8 ;)

Copy link
Contributor

@ptitloup ptitloup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi, merci !

@azmeuk
Copy link
Contributor Author

azmeuk commented May 21, 2024

Je ne sais pas pourquoi l’intégration continue ne passe pas, ça me semble surprenant que ce soit lié au renommage des assertions. Vous avez des idées ?

@azmeuk azmeuk changed the base branch from master to develop May 21, 2024 14:15
@Badatos
Copy link
Collaborator

Badatos commented May 21, 2024

Je ne sais pas pourquoi l’intégration continue ne passe pas, ça me semble surprenant que ce soit lié au renonmage des assertions. Vous avez des idées ?

L'erreur "database table is locked" survient de manière un peu aléatoire. quand ca arrive, il faut juste relancer le CI, je n'ai pas encore trouvé comment faire mieux :/

@ptitloup ptitloup merged commit fc458ee into EsupPortail:develop May 21, 2024
3 checks passed
@azmeuk azmeuk deleted the deprecations branch May 21, 2024 15:55
LoanR pushed a commit to yaal-coop/Esup-Pod that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants