Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong path #6

Open
simonox opened this issue Jul 10, 2017 · 4 comments
Open

Wrong path #6

simonox opened this issue Jul 10, 2017 · 4 comments
Assignees

Comments

@simonox
Copy link

simonox commented Jul 10, 2017

Custom entitlements are copies to folder platforms/iOS.

In NativeScript 3.1.2 the folder is named platforms/ios:

This does not work on a case sensitive file system.

I think I am going to create a PR.

simonox pushed a commit to simonox/nativescript-custom-entitlements that referenced this issue Jul 10, 2017
@simonox
Copy link
Author

simonox commented Jul 18, 2017

NativeScript 3.1 already has this as a built-in feature (currently broken): NativeScript/nativescript-cli#2946

No need to use this plugin after this feature is fixed in NativeScript.

@spike1292
Copy link
Member

@simonox tnx you for your feedback. I'm going to update our app to nativescript 3.1 so will also take a look at this problem.
A least nice to see that the cli has the same problem 😉

@gbonline
Copy link

gbonline commented Aug 1, 2017

Hi, I've updated tns to the last 3.1.3 version, but this issue still remain on iOS dev environment

@spike1292 spike1292 self-assigned this Aug 1, 2017
@spike1292
Copy link
Member

spike1292 commented Aug 1, 2017

In the demo project we don't have this problem. Here https://github.com/Essent/nativescript-custom-entitlements/blob/master/lib/after-prepare.js#L10 you can see that we use lowercase ios. So I don't think it is this plugin.
I think the problem is in the nativescript-cli see: https://github.com/NativeScript/nativescript-cli/blob/master/lib/services/ios-entitlements-service.ts#L25 where this.$devicePlatformsConstants.iOS resolves to iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants