Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stotymap feature layer with polygon support #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sharif26
Copy link

@sharif26 sharif26 commented Sep 2, 2016

Hello

Story Map is a great tool for story telling with GIS data.
Now we got a feature layer with polygon shape.
But unfortunately it only works with point data and I found that there are some requests for polygon.
So I tried to change the code so that it also works with polygon feature layer.
I just put the centroid of the polygon wherever necessary and also change few condition to support polygon.
Please review my fork & pull request.
It may not be fully complete, but it works with our current polygon feature and webmap.
So I think it can be a good start.

Have a great long weekend.
Thanks in advance
Sharif Ahmed
9/2/2016

coded added to handle feature layer with polygon, getCentroid() function is used in case of polygon type.
code changed to support polygon shape.
added code to support polygon shape
@glazou
Copy link

glazou commented Sep 2, 2016

Hi @sharif26,
Thanks for contributing, it looks good. We just wrapped up our upcoming release so we won't have time to review this right now, but we will consider your contribution for a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants