Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue979 - Add custom params support #1036

Merged
merged 4 commits into from
Jan 5, 2018
Merged

Issue979 - Add custom params support #1036

merged 4 commits into from
Jan 5, 2018

Conversation

Biboba
Copy link
Contributor

@Biboba Biboba commented Jan 2, 2018

  • TiledMapLayer, DynamicMapLayer, FeatureLayer, ImageMapLayer support customs params in url (just like Leaflet):
    L.esri.tiledMapLayer({ url: 'http://services.arcgisonline.com/ArcGIS/rest/services/USA_Topo_Maps/MapServer?foo=bar' })

  • Customs parameters can also be defined with a 'resquestParams' option:
    L.esri.tiledMapLayer({ url: 'http://services.arcgisonline.com/ArcGIS/rest/services/USA_Topo_Maps/MapServer', requestParams : { foo: bar } })

  • Tests

@jgravois
Copy link
Contributor

jgravois commented Jan 2, 2018

this one looks good too @Biboba! i'll review more fully soon.

@jgravois
Copy link
Contributor

jgravois commented Jan 5, 2018

since you extended L.esri.Task i added tests for inheriting classes as well. this is very cool @Biboba. thank you!

@jgravois jgravois merged commit f203122 into Esri:master Jan 5, 2018
jgravois added a commit to jgravois/esri-leaflet that referenced this pull request Apr 23, 2022
Issue979 - Add custom params support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants