Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powered by ESRI attribution logo obscures leaflet controls with position: 'bottomright' #210

Closed
ChrisCSmith opened this issue Feb 13, 2014 · 3 comments
Closed

powered by ESRI attribution logo obscures leaflet controls with position: 'bottomright' #210

ChrisCSmith opened this issue Feb 13, 2014 · 3 comments
Assignees
@patrickarlt
Milestone
Beta 6

Comments

@ChrisCSmith
Copy link

If a control is added to leaflet with position: 'bottomright' and an ESRI basemap layer is then displayed, the powered by ESRI attribution logo obscures the leaflet control.

controlbottomright
obscuredcontrolbottomright
@patrickarlt patrickarlt self-assigned this Feb 14, 2014
@patrickarlt patrickarlt added this to the Beta 4 milestone Feb 14, 2014
@patrickarlt
Copy link
Contributor

Looks like we need a logoPosition option on L.esri.BasemapLayer.

@patrickarlt patrickarlt modified the milestones: Beta 5, Beta 4 Feb 25, 2014
@patrickarlt patrickarlt modified the milestones: Beta 6, Beta 5 Jun 18, 2014
@patrickarlt
Copy link
Contributor

Moving this to Beta 6. This is probably best implemented as a custom control (L.esri.Controls.Logo) The will be added bottomright by default. Making it an actual control means it should play nice with other controls in a similar position.

@davidrs
Copy link

davidrs commented Aug 5, 2014

Glad to see this ticket. Should also fix the issue of having strange layout if setting leaflet attribution to bottomleft. Fiddle here shows the issue. Our fix is commented out in the CSS:
http://jsfiddle.net/h62kX/

patrickarlt added a commit that referenced this issue Aug 6, 2014
@patrickarlt
Merge pull request #323 from patrickarlt/master
13d7753 
fix #210
jgravois pushed a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@patrickarlt
fix Esri#210
c6bc8ed
jgravois pushed a commit to jgravois/esri-leaflet that referenced this issue Apr 23, 2022
@patrickarlt
Merge pull request Esri#323 from patrickarlt/master
9e2f5ca 
fix Esri#210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickarlt patrickarlt

Labels
None yet
Projects
None yet
Milestone
Beta 6
Development

No branches or pull requests
3 participants
@patrickarlt @davidrs @ChrisCSmith