Allow users to set preserveDrawingBuffer in the options #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that printing maps rendered with
esri-leaflet-vector
does not work in Firefox.An issue was created here.
This PR fixes that issue by allowing the user to set
preserveDrawingBuffer
totrue
, which resolves the issue. It is set tofalse
by default in themaplibre-gl-js
project in thescr/ui/map.ts
file for performance optimizations. Adding the ability for a user to toggle this value throughesri-leaflet-vector
, but maintaining a default offalse
will help users who want to provide printing capabilities, while maintaining the performance optimization for those who do not have this need.