-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement v2 styles endpoint and update layer inheritance #182
Conversation
Co-authored-by: Gavin Rehkemper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems to work for me. A few small things:
}) | ||
}).to.throw('The \'language\' parameter is not supported for custom basemap styles') | ||
}) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a unit test for the new functionality "it should load a v2 basemap if using a v2 basemap key enum even if not passing the version: 2
property" - can you add a unit test for that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor code suggestion but please add the test that @gavinr has indicated.
Co-authored-by: Gavin Rehkemper <[email protected]> Co-authored-by: Patrick Arlt <[email protected]>
Released in v4.1.0. |
Implements #150 #174 #170
#150 - Change VectorBasemapLayer to inherit from VectorTileLayer
onAdd
and_createMaplibreLayer
from VectorTileLayer, and performs asuper
call to the VectorTileLayer constructor.onRemove
and_asyncAdd
, due to the dynamic data attribution in VectorBasemapLayer#174 - add support for the v2 basemap styles service
(see #175)
getBasemapStyleV2Url
function that returns a formatted reference to the new v2 endpointversion
parameter inVectorBasemapLayer
that specifies the endpoint to access (1 or 2) If not provided, the version will attempt to set itself based on the provided style enumerationlanguage
parameter that works with v2 of the service, accepts valid language parameters#170 - fix default pane for VectorBasemapLayer
(see #181)
tilePane
esri-details
pane for styles of type:Details
//details
esri-labels
pane to display below theoverlayPane