Switch to use Maplibre GL JS #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickarlt
requested changes
Aug 19, 2022
There was a problem hiding this comment.
@gavinr this looks great. I think that:
- We should keep
opacity,getOpacity()andsetOpacity()these are relatively simple and we should keep the same API. - We should keep
styleLoadedfor the same reason. - Incorporate my fix in Add reproduction for and fix for #130 #144
- Release this as 4.0.0
# Conflicts: # package-lock.json
|
@patrickarlt thanks - I have addressed those points in this branch. Please review and then I'll release it as v4.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#139
Switched to using maplibre-gl-js, using maplibre-gl-leaflet as inspiration.
Some notes:
getOpacityandsetOpacityare not in maplibre-gl-leaflet - I could not remember if we have added that intentionally in our version or not. I removed it, but if it was serving a specific purpose we should probably leave it in.Same as above for the(Fixed)styleLoadedevent - should we include this or remove it?