Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port createNewLayer from L.esri.featureLayer for renderer plugin #31

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Jun 20, 2020

just a small tweak to make Cluster.featureLayer look more like esri.featureLayer for the sake of Esri/esri-leaflet-renderers#158

to be honest, i have no clue how this was working in [email protected]

@jgravois
Copy link
Contributor Author

jgravois commented Jun 22, 2020

this branch has been rebased.

for this PR or any other i ever open, feel free to pile on additional commits, --force push, rebase, close or do anything else you'd like at will.

@gavinr
Copy link
Contributor

gavinr commented Jun 22, 2020

@jgravois I was in the process but a meeting popped up and you beat me to it. thanks much though!

Copy link
Contributor

@gavinr gavinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@gavinr gavinr merged commit bef6011 into Esri:master Jun 22, 2020
@gavinr
Copy link
Contributor

gavinr commented Jun 22, 2020

released in https://github.com/Esri/esri-leaflet-cluster/releases/tag/v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants