revert: feat(icon): type icon names (#9650) #9910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9c2ba2f.
github-actions
bot
added
the
chore
jcfranco
approved these changes
Jul 30, 2024
benelan
added
the
skip visual snapshots
* origin/dev: build(deps): drop unnecessary ESM resolution build patch (#9907)
|
It appears the issue was related to the Stencil 4.19 changes, which was resolved in #9907. Closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9909
Summary
Revert adding the icons as a dependency to resolve build errors in SSR apps.
This reverts commit 9c2ba2f.