build: regenerate package lock due to build errors #9774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Elijbet I noticed this aims to update the lockfile. Could you please share the reason for this? |
I kept running an error when trying to npm install after pulling the latest to dev. After troubleshooting with Ben he asked me to open a PR if the re-install made changes to |
benelan
changed the title
benelan
requested review from
benelan,
jcfranco,
driskull and
geospatialem
as code owners
* origin/dev: build(deps): update dependency @floating-ui/dom to v1.6.7 (#9766)
github-actions
bot
added
the
chore
|
@Elijbet there were merge conflicts so I regenereted the package-lock again and pushed to this branch. Before merging, can you run the following to confirm the build issues aren't reintroduced: git clean -fdx && npm install && npm run build |
|
Awesome. Thank you both for the context and the PR! ✨💪✨ |
Looks good. Merging. |
Elijbet
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Jul 15, 2024
…-to-monorepo * origin/dev: (206 commits) fix(tile): center align slot's text when alignment is equal to center (#9773) build: regenerate package lock due to build errors (#9774) build(deps): update dependency @floating-ui/dom to v1.6.7 (#9766) chore(common-tests): add themed test helper (#9763) chore: release next fix(shell): update shell to correctly position calcite shell panel at shell's bottom (#9748) chore: release next fix(tile): center align contentTop and contentBottom slots when alignment prop equals "center" (#9732) chore: release next chore(tree-item): fix mutable warning `indeterminate` prop (#9760) fix(panel, flow-item): fix footer-padding CSS prop regression (#9757) build(deps): update angular monorepo to v18 (major) (#9587) chore: release next Chore: remove component usage files (#9052) fix(input-number): restore decimal input mode default (#9741) test(panel, flow-item): add scale control to simple stories (#9747) chore: release next feat(panel, flow-item): add scale property (#9730) chore: release next fix(segmented-control): Make check state update correctly (#9733) ...
benelan
added a commit
that referenced
this pull request
Jul 15, 2024
**Related Issue:** #9774 ## Summary Revert the package-lock.json changes in the above PR due to new errors: ``` calcite-design-system/dev/packages/calcite-components/support/generateT9nTypes.ts:1 import globby from "globby"; ^ SyntaxError: The requested module 'globby' does not provide an export named 'default' at ModuleJob._instantiate (node:internal/modules/esm/module_job:134:21) at async ModuleJob.run (node:internal/modules/esm/module_job:217:5) at async ModuleLoader.import (node:internal/modules/esm/loader:323:24) at async loadESM (node:internal/process/esm_loader:28:7) at async handleMainPromise (node:internal/modules/run_main:113:12) Node.js v20.12.1 npm ERR! Lifecycle script `util:generate-t9n-types` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @esri/[email protected] npm ERR! Lifecycle script `util:prep-build-reqs` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @esri/[email protected] npm ERR! Lifecycle script `build` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @esri/[email protected] ```
benelan
added a commit
that referenced
this pull request
Jul 16, 2024
benelan
added a commit
that referenced
this pull request
Jul 19, 2024
**Related Issue:** #9774, #9779, #9790, #9797 ## Summary Resolve build errors related to Nx Native Modules using a solution from lerna/lerna#3815 (comment) Nx documented additional troubleshooting steps for this common error: https://nx.dev/troubleshooting/troubleshoot-nx-install-issues
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
## Summary
Re-generate `package-lock.json` to resolve a build error on osx
machines.
```
Error: Cannot find module '@nx/nx-darwin-arm64'
Require stack:
- /Users/eli97736/Documents/calcite-components/node_modules/nx/src/native/index.js
- /Users/el1i97736/Documents/calcite-components/node_modules/nx/src/hasher/node-task-hasher-impl.js
- /Users/e1i97736/Documents/calcite-components/node_modules/nx/src/hasher/task-hasher.js
- /Users/e1i97736/Documents/calcite-components/node_modules/nx/src/hasher/hash-task.js
- /Users/e1i97736/Documents/calcite-components/node_modules/nx/src/tasks-runner/run-command.js
- /Users/e1i97736/Documents/calcite-components/node_modules/nx/srce/nx-cloud/utilities/get-cloud-options.js
- /Users/e1i97736/Documents/calcite-components/node_modules/nx/bin/post-install.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1143:15)
at Function.resolve (node:internal/modules/helpers:190:19)
at Module._load (/Users/el1i97736/Documents/calcite-components/node_modules/nx/src/native/index.js:53:36)
at Module.require (node:internal/modules/cjs/loader:1231:19)
at require (node:internal/modules/helpers:179:18)
at Object.<anonymous> (/Users/eli97736/Documents/calcite-components/node_modules/nx/src/native/native-bindings.js:135:29)
at Module._compile (node:internal/modules/cjs/loader:1369:14)
at Module._extensions.js (node:internal/modules/cjs/loader:1427:10)
at Module.load (node:internal/modules/cjs/loader:1206:32)
at Module._load (node:internal/modules/cjs/loader:1022:12) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/Users/e1i197736/Documents/calcite-components/node_modules/nx/srce/native/index.js',
'/Users/e1i97736/Documents/calcite-components/node_modules/nx/srce/hasher/node-task-hasher-impl.js',
'/Users/e1i97736/Documents/calcite-components/node_modules/nx/srce/hasher/task-hasher.js',
'/Users/e1i97736/Documents/calcite-components/node_modules/nx/src/hasher/hash-task.js',
'/Users/e1i197736/Documents/calcite-components/node_modules/nx/src/tasks-runner/run-command.js',
'/Users/e1i97736/Documents/calcite-components/node_modules/nx/src/nx-cloud/utilities/get-cloud-options.js',
'/Users/e1i97736/Documents/calcite-components/node_modules/nx/bin/post-install.js'
]
}
```
Co-authored-by: Ben Elan <[email protected]>
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** #9774 ## Summary Revert the package-lock.json changes in the above PR due to new errors: ``` calcite-design-system/dev/packages/calcite-components/support/generateT9nTypes.ts:1 import globby from "globby"; ^ SyntaxError: The requested module 'globby' does not provide an export named 'default' at ModuleJob._instantiate (node:internal/modules/esm/module_job:134:21) at async ModuleJob.run (node:internal/modules/esm/module_job:217:5) at async ModuleLoader.import (node:internal/modules/esm/loader:323:24) at async loadESM (node:internal/process/esm_loader:28:7) at async handleMainPromise (node:internal/modules/run_main:113:12) Node.js v20.12.1 npm ERR! Lifecycle script `util:generate-t9n-types` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @esri/[email protected] npm ERR! Lifecycle script `util:prep-build-reqs` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @esri/[email protected] npm ERR! Lifecycle script `build` failed with error: npm ERR! Error: command failed npm ERR! in workspace: @esri/[email protected] ```
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** #9774, #9779, #9790, #9797 ## Summary Resolve build errors related to Nx Native Modules using a solution from lerna/lerna#3815 (comment) Nx documented additional troubleshooting steps for this common error: https://nx.dev/troubleshooting/troubleshoot-nx-install-issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-generate
package-lock.jsonto resolve a build error on osx machines.