fix(combobox): fix error that occurs when a click is emitted when the component is appended to the DOM #9373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component is appended to the DOM
jcfranco
added
the
skip visual snapshots
github-actions
bot
added
the
bug
jcfranco
deleted the
jcfranco/9321-fix-error-when-click-is-emitted-on-combobox-connect
branch
Merged
benelan
pushed a commit
that referenced
this pull request
May 21, 2024
… component is appended to the DOM (#9373) **Related Issue:** #9321 ## Summary This fixes an issue where references to internal elements were undefined in the window-level click handler. This would happen because the window click handler was added when the component was connected, but before its internals were rendered.
benelan
added a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.3</summary> ## [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) ### Bug Fixes * **combobox:** Fix error that occurs when a click is emitted when the component is appended to the DOM ([#9373](#9373)) ([34a2bbe](34a2bbe)) </details> <details><summary>@esri/calcite-components-angular: 2.8.3</summary> ## [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.2 to ^2.8.3 </details> <details><summary>@esri/calcite-components-react: 2.8.3</summary> ## [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.2 to ^2.8.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ben Elan <[email protected]>
benelan
added a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.3</summary> [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) * **combobox:** Fix error that occurs when a click is emitted when the component is appended to the DOM ([#9373](#9373)) ([34a2bbe](34a2bbe)) </details> <details><summary>@esri/calcite-components-angular: 2.8.3</summary> [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.2 to ^2.8.3 </details> <details><summary>@esri/calcite-components-react: 2.8.3</summary> [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.2 to ^2.8.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Ben Elan <[email protected]>
Merged
jcfranco
pushed a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.8.3</summary> [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) * **combobox:** Fix error that occurs when a click is emitted when the component is appended to the DOM ([#9373](#9373)) ([34a2bbe](34a2bbe)) </details> <details><summary>@esri/calcite-components-angular: 2.8.3</summary> [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) * **@esri/calcite-components-angular:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.2 to ^2.8.3 </details> <details><summary>@esri/calcite-components-react: 2.8.3</summary> [2.8.3](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-05-21) * **@esri/calcite-components-react:** Synchronize components versions * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.8.2 to ^2.8.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: Calcite Admin <[email protected]>
Merged
jcfranco
added a commit
that referenced
this pull request
Jun 4, 2024
…via a click (#9501) **Related Issue:** #9504 ## Summary This fixes an issue where any clicks when the popover is connected to the DOM would cause it to be immediately closed. This would happen because `PopoverManager`'s window `click` handler was being added and invoked during `connectedCallback` and not after the component was initialized (somewhat similar to #9373). **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
benelan
pushed a commit
that referenced
this pull request
Jun 25, 2024
…via a click (#9501) **Related Issue:** #9504 ## Summary This fixes an issue where any clicks when the popover is connected to the DOM would cause it to be immediately closed. This would happen because `PopoverManager`'s window `click` handler was being added and invoked during `connectedCallback` and not after the component was initialized (somewhat similar to #9373). **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
benelan
pushed a commit
that referenced
this pull request
Jun 25, 2024
…via a click (#9501) **Related Issue:** #9504 ## Summary This fixes an issue where any clicks when the popover is connected to the DOM would cause it to be immediately closed. This would happen because `PopoverManager`'s window `click` handler was being added and invoked during `connectedCallback` and not after the component was initialized (somewhat similar to #9373). **Note**: there are no accompanying tests as this is not reproducible in the test environment, which uses the lazy-loaded output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9321
Summary
This fixes an issue where references to internal elements were undefined in the window-level click handler. This would happen because the window click handler was added when the component was connected, but before its internals were rendered.