Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input, input-number, input-text): ensure autofocus is available on HTMLElement #9343

Merged
merged 2 commits into from
May 15, 2024
Merged

fix(input, input-number, input-text): ensure autofocus is available on HTMLElement #9343

merged 2 commits into from
May 15, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: #9235

Summary

Exposes autofocus property to ensure the prop/attr is available on the HTMLElement type.

This should no longer be necessary once ionic-team/stencil#5726 is fixed and available in Stencil.

@jcfranco jcfranco requested a review from a team as a code owner May 14, 2024 23:55
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 14, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label May 14, 2024
@jcfranco jcfranco merged commit 405a4b0 into hotfix May 15, 2024
8 checks passed
@jcfranco jcfranco deleted the jcfranco/9235-ensure-autofocus-is-available-on-htmlelement branch May 15, 2024 02:43
@calcite-admin calcite-admin mentioned this pull request May 15, 2024
Merged
@jcfranco
Copy link
Member Author

Note: using @ignore to keep the prop/attr in types and to allow filtering from the doc site.

benelan pushed a commit that referenced this pull request May 15, 2024
@calcite-admin
chore: release hotfix (#9345)
d528897 
🤖 I have created a release *beep* *boop*
---


<details><summary>@esri/calcite-components: 2.8.2</summary>

##
[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)


### Bug Fixes

* **input, input-number, input-text:** Ensure `autofocus` is available
on `HTMLElement`
([#9343](#9343))
([405a4b0](405a4b0))
</details>

<details><summary>@esri/calcite-components-angular: 2.8.2</summary>

##
[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)


### Miscellaneous Chores

* **@esri/calcite-components-angular:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1 to ^2.8.2
</details>

<details><summary>@esri/calcite-components-react: 2.8.2</summary>

##
[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)


### Miscellaneous Chores

* **@esri/calcite-components-react:** Synchronize components versions


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1 to ^2.8.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
benelan pushed a commit that referenced this pull request May 15, 2024
@jcfranco @benelan
fix(input, input-number, input-text): ensure autofocus is available o…
ecc97a9 
…n HTMLElement (#9343)

**Related Issue:** #9235

## Summary

Exposes `autofocus` property to ensure the prop/attr is available on the
`HTMLElement` type.

This should no longer be necessary once
ionic-team/stencil#5726 is fixed and available
in Stencil.
benelan pushed a commit that referenced this pull request May 15, 2024
@calcite-admin @benelan
chore: release hotfix
268f284 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.8.2</summary>

[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)

* **input, input-number, input-text:** Ensure `autofocus` is available
on `HTMLElement`
([#9343](#9343))
([405a4b0](405a4b0))
</details>

<details><summary>@esri/calcite-components-angular: 2.8.2</summary>

[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1 to ^2.8.2
</details>

<details><summary>@esri/calcite-components-react: 2.8.2</summary>

[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1 to ^2.8.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@benelan benelan mentioned this pull request May 15, 2024
Merged
benelan added a commit that referenced this pull request May 15, 2024
@benelan @jcfranco
fix(input, input-number, input-text): ensure autofocus is available o…
27ad10e 
…n HTMLElement (#9343) (#9347)

**Related Issue:** #9235

## Summary

Exposes `autofocus` property to ensure the prop/attr is available on the
`HTMLElement` type.

This should no longer be necessary once
ionic-team/stencil#5726 is fixed and available
in Stencil.

Co-authored-by: JC Franco <[email protected]>
@calcite-admin calcite-admin mentioned this pull request May 15, 2024
Merged
benelan added a commit that referenced this pull request May 17, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/cherry-pick-h…
792f1a8 
…otfix-release

* origin/main:
  chore: release next
  feat(table): Add `selection-display` property (#9355)
  refactor(dropdown-item):  remove unused css classes (#9349)
  chore: release next
  feat(dropdown-item): update spacing of icons (#9330)
  chore: release next
  feat(flow-item): add content-top slot (#9344)
  chore: release next
  feat(flow-item): add content-bottom slot (#9346)
  chore: release next
  fix(input, input-number, input-text): ensure autofocus is available on HTMLElement (#9343) (#9347)
benelan added a commit that referenced this pull request May 18, 2024
@benelan @calcite-admin
chore: release hotfix (#9348)
d6b7116 
🤖 I have created a release *beep* *boop*
---

<details><summary>@esri/calcite-components: 2.8.2</summary>


[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)

* **input, input-number, input-text:** Ensure `autofocus` is available
on `HTMLElement`
([#9343](#9343))

([405a4b0](405a4b0))
</details>

<details><summary>@esri/calcite-components-angular: 2.8.2</summary>


[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)

* **@esri/calcite-components-angular:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1 to ^2.8.2
</details>

<details><summary>@esri/calcite-components-react: 2.8.2</summary>


[2.8.2](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected])
(2024-05-15)

* **@esri/calcite-components-react:** Synchronize components versions

* The following workspace dependencies were updated
  * dependencies
    * @esri/calcite-components bumped from ^2.8.1 to ^2.8.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See

[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: Calcite Admin <[email protected]>
@calcite-admin calcite-admin mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan