Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tile): apply center alignment only to x-axis #9288

Merged
merged 3 commits into from
May 10, 2024
Merged

fix(tile): apply center alignment only to x-axis #9288

merged 3 commits into from
May 10, 2024

Conversation

eriklharper
Copy link
Contributor

@eriklharper eriklharper commented May 8, 2024 •
edited
Loading

Related Issue: #9252

Summary

This PR fixes Tile's alignment="center" option to only horizontally center the primary icon, heading and description.

image

@eriklharper eriklharper requested a review from a team as a code owner May 8, 2024 23:57
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label May 8, 2024
@eriklharper eriklharper added low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible labels May 8, 2024
@eriklharper eriklharper requested review from jcfranco and SkyeSeitz May 8, 2024 23:59
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 9, 2024
jcfranco
jcfranco approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM! ✨🎸✨ Deferring to @SkyeSeitz for visuals review.

Before merging, could you set the visual changes on the issue and not the PR?

packages/calcite-components/src/components/tile-group/tile-group.tsx Outdated Show resolved Hide resolved
packages/calcite-components/src/demos/tile-group.html Show resolved Hide resolved
@eriklharper eriklharper added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 10, 2024
@eriklharper eriklharper merged commit 75df0ba into main May 10, 2024
16 checks passed
@eriklharper eriklharper deleted the eriklharper/9252-tile-center-alignment-only-x-axis branch May 10, 2024 21:39
@calcite-admin calcite-admin mentioned this pull request May 10, 2024
Merged
@eriklharper eriklharper mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem left review comments

@jcfranco jcfranco jcfranco approved these changes

@alisonailea alisonailea alisonailea approved these changes

@SkyeSeitz SkyeSeitz Awaiting requested review from SkyeSeitz

Assignees

@eriklharper eriklharper

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

Successfully merging this pull request may close these issues.
4 participants
@eriklharper @jcfranco @alisonailea @geospatialem