fix(tile): fix spacing between content-top and content-bottom slots #9241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly stuff in both content-top and content-bottom slots
eriklharper
changed the title
eriklharper
added
the
pr ready for visual snapshots
github-actions
bot
added
the
bug
eriklharper
added
the
low risk
jcfranco
approved these changes
May 2, 2024
|
@eriklharper E2E tests are failing, so it looks like tests might also need updating. |
…cription div rendering
…only-content-top-and-bottom
Fixed it. Had to do with removing a conditional for rendering the heading and description divs, which is not necessary for this PR, was a holdover from a previous experiment that I forgot to revert. |
eriklharper
added
pr ready for visual snapshots
Merged
geospatialem
modified the milestones:
2024-05-01 - May maintenance release,
2024-05-28 - May Main Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4701
Summary
This PR corrects the spacing between the
content-topandcontent-bottomslotted content in Tile, ensuring there is a scale-specific gap between the two when both of them are present and none of the other content elements are supplied.