Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): add mode to handle flat and nested lists and improve dragging #9068

Closed
wants to merge 9 commits into from

Conversation

driskull
Copy link
Member

@driskull driskull commented Apr 5, 2024

Related Issue: #8667 #8242

Summary

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 5, 2024
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 5, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 5, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 5, 2024
@driskull
Copy link
Member Author

driskull commented Apr 5, 2024

@ashetland this handles the modes and indentation. Can you take a look?

@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 5, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 5, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Apr 5, 2024
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 13, 2024
# Conflicts:
#	packages/calcite-components/src/components/list-item/list-item.tsx
#	packages/calcite-components/src/components/list/list.tsx
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Apr 13, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Apr 20, 2024
@driskull driskull closed this Apr 22, 2024
@driskull driskull deleted the dris0000/list-visual-changes branch April 22, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant