Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(loader): tidy up styles #8717

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 9, 2024

Related Issue: N/A

Summary

This nests numbered SVG classes and also removes a grid display feature query since all baseline browsers support it.

@jcfranco jcfranco requested a review from a team as a code owner February 9, 2024 07:36
@jcfranco jcfranco added the low risk Issues with low risk for consideration in low risk milestones label Feb 9, 2024
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Feb 9, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 17, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. labels Mar 18, 2024
@jcfranco jcfranco merged commit b05cb3d into main Mar 18, 2024
16 checks passed
@jcfranco jcfranco deleted the jcfranco/tidy-up-loader-styles branch March 18, 2024 20:14
@github-actions github-actions bot added this to the 2024-03-26 - Mar Release milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low risk Issues with low risk for consideration in low risk milestones pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants