Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): Add syntax highlighter code component. #8713

Closed
wants to merge 20 commits into from

Conversation

driskull
Copy link
Member

@driskull driskull commented Feb 9, 2024

Related Issue: WIP

Summary

WIP

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Feb 9, 2024
@driskull
Copy link
Member Author

driskull commented Feb 9, 2024

@macandcheese do you know if we have an issue for this type of component?

@macandcheese
Copy link
Contributor

@macandcheese do you know if we have an issue for this type of component?

No, just the key code one which seems different.

Are we planning on passing through configuration options like lang, line numbering, etc,

We’ll probably want design pass on this for color decisions, spacing, etc. The developer site has a pretty built out one with a ton of functionality, using highlight I think, should we sync with them?

@driskull
Copy link
Member Author

driskull commented Feb 9, 2024

Are we planning on passing through configuration options like lang, line numbering, etc,

Yeah I would think so, I think that depends on the design requirements as well.

We’ll probably want design pass on this for color decisions, spacing, etc. The developer site has a pretty built out one with a ton of functionality, using highlight I think, should we sync with them?

Yes, can we get an issue created for the design? Yes, lets sync with them.

Thanks @macandcheese

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 23, 2024
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label May 26, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 6, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:16
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 13, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 30, 2024
@driskull driskull closed this Jul 23, 2024
@driskull driskull deleted the dris0000/code-highlighter branch July 23, 2024 23:29
@driskull driskull restored the dris0000/code-highlighter branch July 26, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants