feat(panel): Add component tokens #8670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
changed the title
alisonailea
requested changes
Jan 30, 2024
|
Looks good! Just a few little things. |
alisonailea
requested changes
Feb 2, 2024
alisonailea
requested changes
Feb 9, 2024
macandcheese
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Looks good!
I can do a quick follow up for #8675 after this lands - we showed a lot of demo with those customizations this morning 😄
macandcheese
reviewed
Feb 9, 2024
Elijbet
pushed a commit
that referenced
this pull request
Feb 15, 2024
**Related Issue:** #7180 ## Summary - Adds screenshot theming test ### Adds the following public component css properties: * `--calcite-panel-background-color`: Specifies the background color of the component. * `--calcite-panel-border-color`: Specifies the border color of the component. * `--calcite-panel-description-text-color`: Specifies the color of the component's description. * `--calcite-panel-footer-background-color`: Specifies the background color of the component's footer. * `--calcite-panel-footer-space`: Specifies the spacing of the component's footer. * `--calcite-panel-header-background-color`: Specifies the component header's background color. * `--calcite-panel-heading-text-color`: Specifies the component header's color. * `--calcite-panel-header-z-index`: Specifies the component header's z-index. * `--calcite-panel-fab-z-index`: Specifies the component fab's z-index. ## Deprecates the following public component css properties: - `--calcite-panel-footer-padding`: [Deprecated] Use `--calcite-panel-footer-space` instead. Specifies the padding of the component's footer. - `--calcite-panel-header-border-block-end`: [Deprecated] No longer necessary. Specifies the component header's block end border. - `--calcite-panel-header-color`: [Deprecated] Use `--calcite-panel-heading-text-color` instead. Specifies the component header's color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following public component css properties:
--calcite-panel-background-color: Specifies the background color of the component.--calcite-panel-border-color: Specifies the border color of the component.--calcite-panel-description-text-color: Specifies the color of the component's description.--calcite-panel-footer-background-color: Specifies the background color of the component's footer.--calcite-panel-footer-space: Specifies the spacing of the component's footer.--calcite-panel-header-background-color: Specifies the component header's background color.--calcite-panel-heading-text-color: Specifies the component header's color.--calcite-panel-header-z-index: Specifies the component header's z-index.--calcite-panel-fab-z-index: Specifies the component fab's z-index.Deprecates the following public component css properties:
--calcite-panel-footer-padding: [Deprecated] Use--calcite-panel-footer-spaceinstead. Specifies the padding of the component's footer.--calcite-panel-header-border-block-end: [Deprecated] No longer necessary. Specifies the component header's block end border.--calcite-panel-header-color: [Deprecated] Use--calcite-panel-heading-text-colorinstead. Specifies the component header's color.