-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(link): add component tokens #8660
Merged
DitwanP
merged 7 commits into
epic/7180-component-tokens
from
dit13711/add-component-tokens-to-fab-and-link
Feb 16, 2024
Merged
feat(link): add component tokens #8660
DitwanP
merged 7 commits into
epic/7180-component-tokens
from
dit13711/add-component-tokens-to-fab-and-link
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calcite-design-system into dit13711/add-component-tokens-to-fab-and-link
DitwanP
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Jan 26, 2024
eriklharper
reviewed
Jan 26, 2024
eriklharper
reviewed
Jan 26, 2024
alisonailea
requested changes
Jan 30, 2024
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Issues or pull requests that have not had recent activity.
label
Feb 7, 2024
DitwanP
changed the title
feat(fab, link): add component tokens
feat(link): add component tokens
Feb 13, 2024
DitwanP
removed
the
Stale
Issues or pull requests that have not had recent activity.
label
Feb 13, 2024
alisonailea
approved these changes
Feb 14, 2024
DitwanP
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Feb 15, 2024
…calcite-design-system into dit13711/add-component-tokens-to-fab-and-link
DitwanP
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Feb 15, 2024
…calcite-design-system into dit13711/add-component-tokens-to-fab-and-link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Issues tied to a new feature or request.
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Add the following component tokens to the
link
component:--calcite-link-text-color
: Specifies the text color of the component.--calcite-link-icon-start-color
: Specifies the color of the component's start position icon.--calcite-link-icon-end-color
: Specifies the color of the component's end position icon.Also fixed the end icon demo for
link
. (the icon was set to the start position)