feat(meter): Add component tokens #8606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macandcheese
added
the
pr ready for visual snapshots
macandcheese
commented
Jan 13, 2024
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
macandcheese
removed
the
Stale
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
requested changes
Feb 9, 2024
macandcheese
removed
the
Stale
macandcheese
added
pr ready for visual snapshots
|
Reviewer note: The font color change for unit are expected and verified by cc @SkyeSeitz @ashetland |
macandcheese
added
pr ready for visual snapshots
macandcheese
added
pr ready for visual snapshots
alisonailea
approved these changes
Feb 17, 2024
| --calcite-meter-space-internal: theme("spacing[0.5]"); | ||
| --calcite-meter-height-internal: theme("spacing.4"); | ||
| --calcite-meter-font-size-internal: var(--calcite-font-size--1); | ||
| --calcite-internal-meter-space: var(--calcite-spacing-base); |
There was a problem hiding this comment.
can we add these other internal vars to the Local props list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following public component css properties:
--calcite-meter-background-color: Specifies the background color of the component.--calcite-meter-border-color: Specifies the border color of the component and displayed step lines.--calcite-meter-shadow: Specifies the box shadow of the component.--calcite-meter-corner-radius: Specifies the corner radius of the component.--calcite-meter-fill-color: Specifies the color of the component's fill.--calcite-meter-range-text-color: Specifies the color of the component's range labels.--calcite-meter-value-text-color: Specifies the color of the component's value label.Adds a Chromatic test and a demo page example.