Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list, list-item, list-item-group): update indentation padding and element spacing for better visual hierarchy #8516

Closed
wants to merge 23 commits into from
Closed

fix(list, list-item, list-item-group): update indentation padding and element spacing for better visual hierarchy #8516

wants to merge 23 commits into from

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 28, 2023 •
edited
Loading

Related Issue: #7100

Summary

  • Update handle padding so that its min width is 32px.
  • Update list indentation to 28px
  • Update list indentation to indent the whole nested list item
  • Update list cells to have a min width of 32px for a bigger hit area

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Dec 28, 2023
@driskull driskull changed the title fix(list, list-item, list-item-group): update indentation padding and element spacing for better visual hierarchy. #7100 fix(list, list-item, list-item-group): update indentation padding and element spacing for better visual hierarchy Dec 28, 2023
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 28, 2023
@driskull driskull requested a review from ashetland December 28, 2023 19:53
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 29, 2023
@driskull
Merge branch 'main' into dris0000/list-visual-hierarchy-7100
e74bd5a 
# Conflicts:
#	packages/calcite-components/src/components/list-item/list-item.scss
#	packages/calcite-components/src/components/list-item/resources.ts
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 2, 2024
@driskull
Merge branch 'main' into dris0000/list-visual-hierarchy-7100
54ca018 
# Conflicts:
#	packages/calcite-components/src/components/list-item/list-item.tsx
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jan 10, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Jan 18, 2024
@driskull driskull closed this Apr 5, 2024
@driskull driskull deleted the dris0000/list-visual-hierarchy-7100 branch April 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashetland ashetland Awaiting requested review from ashetland

Assignees

@driskull driskull

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing. Stale Issues or pull requests that have not had recent activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@driskull