-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(input-date-picker, date-picker): improve date picking experience #8402
Merged
anveshmekala
merged 197 commits into
dev
from
anveshmekala/3455-add-month-and-year-picker
Oct 23, 2024
Merged
Changes from 177 commits
Commits
Show all changes
197 commits
Select commit
Hold shift + click to select a range
b5d8eff
feat(month-picker): adds month-picker component
anveshmekala 78c58eb
emit change event when month is selected
anveshmekala 963868b
redesign month-picker and adds year-picker
anveshmekala 47449cf
add range and emit change event in year-picker
anveshmekala 2d67c2b
disable years based on start and end year selected
anveshmekala 2657e2c
add year picker and month picker in date-picker-header
anveshmekala cfad87b
add second date-picker in input-date-picker when range is enabled
anveshmekala bf7179b
revert input-date-picker changes and update date-picker for range
anveshmekala d1a0da2
simplify calendar render logic
anveshmekala 11f48d8
allows editing date values and navigating using action buttons
anveshmekala 6967b7b
clean up
anveshmekala d813943
allows start date in range to be greater than end date, unhide date-…
anveshmekala ba51c6b
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 8e2dac9
avoid closing date-picker while editing start date & remove methods i…
anveshmekala 2325640
update displayedDate only on blur in date-picker
anveshmekala 33f55a2
refactor updating activeStartDate and activeEndDate
anveshmekala 2ee6fbe
fix minDate for start calendar when activeRange is set to end
anveshmekala 5399e2b
add readme files
anveshmekala 7dcfa61
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 36ed5a3
skip tests related to input year in month-header
anveshmekala ea4308c
fix keyboard selection
anveshmekala 12b2d84
restore focus on to endinput after day selection
anveshmekala 177d0c6
reset endDate when user select startDate beyond endDate & disable pre…
anveshmekala c4cd1fa
avoid updating activeDate of date-picker while selecting date range i…
anveshmekala e9d1863
update demo page for debugging
anveshmekala 1a45455
fixes closing of date-picker while user is editing startDate
anveshmekala f78fb8a
do not update activeDate when start and endDate is from same month
anveshmekala 42952d9
resolve updating activeDate before closing date-picker
anveshmekala 8e300f5
adds date-picker-month-range component and refactor
anveshmekala 49689bf
fix month-header selection issue when wide names are displayed
anveshmekala 92bedd7
adds readme
anveshmekala b6ee675
update activeDates when user is actively typing
anveshmekala aa7f877
fix dimensions of date-picker
anveshmekala 1d507fe
fix date-picker tests
anveshmekala 7b41afd
fix input-date-picker tests
anveshmekala e165457
refactor test utility methods in input-date-picker
anveshmekala 28031ef
add date-picker visibility assertion for user interaction tests
anveshmekala fbec450
add more tests
anveshmekala 94ba93a
drop date-picker-month-range component and refactor date-picker-month…
anveshmekala 55d0f76
update tests
anveshmekala 09bbb24
add test and remove watcher for activeRange in date-picker
anveshmekala c36c694
update test and update calendar when user types a valid date
anveshmekala 237e414
restore watch handler for valueAsDate prop in date-picker for range
anveshmekala 3e74210
fix test failures
anveshmekala bdb0a8c
fix activeDate when min and max are before the current date
anveshmekala 9abb3b9
lets users to navigate months when valueAsDate is parsed
anveshmekala f40cb99
restore activeEndDate
anveshmekala 5827054
add more stories
anveshmekala 903cd3d
add delay for stories with open prop
anveshmekala 1a92e37
replace year-picker with select
anveshmekala 96ef22d
drop year-picker and month-picker components
anveshmekala 0952df2
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 4e4aea7
update stencil config
anveshmekala fe6f1cb
unskip tests in date-picker
anveshmekala 60c2c2d
fix tests
anveshmekala a9bc158
add more tests and update
anveshmekala a0151e5
allow users to specify month abbreviations
anveshmekala 033daa9
add hover effect for keyboard navigation of dates
anveshmekala 0d93b2f
update focus order
anveshmekala e51f3f2
fix navigation chevron positions
anveshmekala 776afa9
add more tests
anveshmekala 704db7f
fix start date selection beyond endDate
anveshmekala 8718c80
update selectDayInMonth test util method
anveshmekala 3ab9b12
fix updating dates from previous and next calendars using keyboard
anveshmekala 0845336
handle keydown events only on calendar container in date-picker-month
anveshmekala 6df3d3e
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 082a9e4
add new focus behavior
anveshmekala 209a45c
fixes updating dates via keyboard
anveshmekala 1f5b745
fix pageUp & pageDown keys
anveshmekala d8eb8c3
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 18d71eb
do not update activedate when updating start or end dates if selected…
anveshmekala 4e071ea
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 423c05a
fix range hover color and selection
anveshmekala ca7baae
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 39880ce
fix date-picker tests and merge master
anveshmekala f01580a
fix input date picker tests
anveshmekala 0e17d56
fixes hover edge cases and adds tests
anveshmekala 9762856
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala d2363a5
add range hover tests in input-date-picker
anveshmekala 91e6616
delete unrelated tests
anveshmekala 2fa6704
do not shift focus onto endDate and do not update activeDate after in…
anveshmekala 942f4e9
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala e86dd1d
fix test failures
anveshmekala 8e6ac05
clean up
anveshmekala a1f5305
refactor test utils
anveshmekala b92066f
remove overlapping dates in range calendar
anveshmekala 10bc852
add divider for horizontal input
anveshmekala d387989
update vertical arrow indicator positioning
anveshmekala c48c8d5
removes redndant wrapper containers and css styling
anveshmekala 3e8750e
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 90b7baf
add box-shadow on focus for selected dates
anveshmekala 2151b09
adds default z-index when focused
anveshmekala d61deb1
refactor date-picker header UI
anveshmekala 942886f
refactor and cleanup date-picker-month styles
anveshmekala fdc27b4
fix vertical layout
anveshmekala 9adc695
fix divider in vertical layout
anveshmekala a23038e
fix test failures
anveshmekala ab81f66
exclude keydownHandler for date-picker-month-header in date-picker-month
anveshmekala 3149b83
fix chevron-icon hover and focus color
anveshmekala b7ad043
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 67373e5
fix chevron dimensions
anveshmekala a360305
fix focus outline for chevrons
anveshmekala 6df6a9a
update test to query calcite-action for navigation & no longer update…
anveshmekala 5cff93b
adds support for arrowUp & fix bugs
anveshmekala 90f5fc9
add interaction tests for input-date-picker
anveshmekala a26d53b
Merge branch 'main' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 3677c59
restore default story object
anveshmekala 7947648
fix dependency issue
anveshmekala 11368ab
fix play function failure in chromatic
anveshmekala 719aec6
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala fa118f9
wait for component query in interaction tests
anveshmekala c0c04c4
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 7f9e0b5
extend timeout in interaction test
anveshmekala f80c77b
feedback changes
anveshmekala c24967f
more feedback changes
anveshmekala 1295da8
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 58adb4d
dynamic width for select menu and disable month option outside of range
anveshmekala 8943f0a
disable year and month outside of range
anveshmekala 943e890
reset activeDate when first valid month is viewed in end calendar
anveshmekala ccbb768
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 4b1325b
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 9f6e1ac
fix test failures
anveshmekala bb536c0
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala f00afc8
restore previous and nextdates in range calendar
anveshmekala 3b1fa1c
add tests
anveshmekala 2ccdd8e
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 484fedd
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 9fb89e0
add tests for select menu
anveshmekala 52763e3
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 4f4a4f3
make noncurrent days in range calendar transparent
anveshmekala 05f542d
fix month picker large scale block size
anveshmekala ff9bb1b
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 0a66124
cleanup
anveshmekala 95c24da
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 1eecd21
refactor
anveshmekala 7e33fd7
fix build errors
anveshmekala 12d474c
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 25c3190
restore wrapper block size in select small scale
anveshmekala d6d1a05
reset line height in select component
anveshmekala fe9ff0f
feedback changes
anveshmekala 8e2c7c4
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala ff383f2
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala cc7f046
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 3d85cc8
add focus border when extending range via mouse
anveshmekala 9a058c2
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 724ab62
fix tests and remove unused messages
anveshmekala b88738b
fix tests
anveshmekala a4a2947
add current day class when in view
anveshmekala a5a42c9
revert fousing current day when switching between months
anveshmekala f0808d1
remove unused methods
anveshmekala cc566a1
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 03d6624
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 8c91509
disable next month chevron when user is viewing last month & allow ar…
anveshmekala 63d3718
feedback changes
anveshmekala edab079
add render test in date-picker-month-header
anveshmekala 1dfb54a
fix tests
anveshmekala 05c9a79
use css tokens where required
anveshmekala 725e701
cleanup
anveshmekala 9cbcb8a
add more tests
anveshmekala 42e1b92
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala b5d6994
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala be10a92
fix build failure
anveshmekala 813ef02
add tests #10113
anveshmekala 8ad76ee
refactor tests
anveshmekala fa404a2
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala c6d31a2
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala b64e66f
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 6b76193
restore input for year in month-header
anveshmekala f6ca9f2
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala e7bedd5
add more testing and fix edge cases with min/max
anveshmekala 2f70dc1
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala a1c540c
fix #10291
anveshmekala 90f1e92
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala f3f3697
fix closing date-picker when fetching last valid month with action ch…
anveshmekala 50c4bee
fix focus order for year first locales
anveshmekala ddf6fb4
add delay for input date picker stories
anveshmekala ab681b7
add wrapper for stories
anveshmekala 4a4f579
remove inline css for wrapper in stories
anveshmekala 8d9f895
add height for story container wrapper
anveshmekala 8c270a2
feedback changes
anveshmekala f5066a2
more cleanup
anveshmekala 62c9569
more cleanup & refactor
anveshmekala 8cd7f5c
fix rem to px mapping in header
anveshmekala 8c2abfd
fix flaky screenshot test
anveshmekala 3b34c2f
update focus stories
anveshmekala 1abbe21
add test for #10301
anveshmekala f6eb79a
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala ef570ea
fix hover outline transition for year
anveshmekala 8d9b339
fix font family for year
anveshmekala d278bf8
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala b5f0474
more feedback changes
anveshmekala 71d2cb5
fix flaky test
anveshmekala 682ec6f
fix #10490
anveshmekala 5b62353
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala ca65a98
refactor
anveshmekala 03117b0
Merge branch 'dev' into anveshmekala/3455-add-month-and-year-picker
anveshmekala 58db674
fix font-weight cascade in select
anveshmekala File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create an issue or add a comment to #7180 to consider this one? Applies to internal
calcite-select
custom CSS props as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action
tokens are installed i believe and tokens added in this PR areinternal
. Adding @alisonailea for review.Will add a comment in the issue for
select
&date-picker
related.