Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync calcite components with design token updates #8219

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 20, 2023

Related Issue: #7325

Summary

Sharing some changes I needed to make to restore component builds and tests. Feel free to cherry-pick and correct as needed. Note that this does not include updates to documentation, stories nor demo pages. Also, most CSS props defined in styles/global.scss were not renamed.

Sharing some other things I spotted:

  • some generated token values don't seem to be valid, found one example:
    // `css/core.css` – note opacity vars at the end
    --calcite-box-shadow-4: 0 12px 32px -2px rgba(0, 0, 0, calcite-opacity-10);
    --calcite-box-shadow-3: 0 4px 20px 0 rgba(0, 0, 0, calcite-opacity-8);
    --calcite-box-shadow-2: 0 4px 16px 0 rgba(0, 0, 0, calcite-opacity-8);
    --calcite-box-shadow-1: 0 2px 8px 0 rgba(0, 0, 0, calcite-opacity-4);
    
  • might need additional cleanup for redundant vars defined in styles/global.scss (some are still using the old name)
  • breaking changes notes from feat!: reduce global design tokens in calcite.css #8215 should emphasize renamed vars (namely with app and ui scopes).
  • design token scss output files may be using newer features that stencil-sass doesn't understand (e.g., @forward, conditional media query imports, issue resolving relative CSS paths when importing index.scss (triggered by the index.css import).

@jcfranco jcfranco requested a review from alisonailea November 20, 2023 11:43
@alisonailea alisonailea merged commit 54f4746 into astump/7325-reduce-tokens-output Nov 21, 2023
3 checks passed
@alisonailea alisonailea deleted the jcfranco/7325-sync-with-calcite-components branch November 21, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants