feat: add icon tokens #8008
Merged
feat: add icon tokens #8008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonailea
requested review from
benelan,
jcfranco,
driskull,
geospatialem and
a team
as code owners
github-actions
bot
added
the
enhancement
alisonailea
added
the
low risk
|
Our icon scales are: But the token sizing values applied are the following, right?... 7=28px |
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
alisonailea
removed
the
Stale
core.sizing.7 = 16px |
alisonailea
added
the
skip visual snapshots
github-actions
bot
added this to the 2023 October Priorities - Maintenance Release milestone
Merged
benelan
pushed a commit
that referenced
this pull request
Oct 30, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-design-tokens: 1.1.0</summary> ## [1.1.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-30) ### Features * Add icon tokens ([#8008](#8008)) ([3623df1](3623df1)) * Add js platform formats to calcite-design-tokens ([#8044](#8044)) ([0e1fefb](0e1fefb)) * Add xxs breakpoint to tokens ([#7992](#7992)) ([05512b6](05512b6)) * Reorganize breakpoints ([#7994](#7994)) ([c64a059](c64a059)) </details> <details><summary>@esri/calcite-components: 1.10.0</summary> ## [1.10.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-30) ### Features * **block:** Ensure chevron is always displayed ([#8014](#8014)) ([95fecb2](95fecb2)) * **navigation-logo:** Adds `icon` and `iconFlipRtl` properties ([#8054](#8054)) ([049056d](049056d)) * **stepper,stepper-item:** Adds support for built-in translations ([#8002](#8002)) ([bb91624](bb91624)) ### Bug Fixes * **button, fab, inline-editable, split-button:** Prevent redundant opacity when button is both loading and disabled ([#8015](#8015)) ([3a1d3fd](3a1d3fd)) * **combobox:** Clear custom input value on blur ([#8070](#8070)) ([327ff06](327ff06)) * **combobox:** Ensure icon scales are consistent ([#8075](#8075)) ([babba3b](babba3b)) * **filter:** Corrects the accessible label ([#8069](#8069)) ([c203084](c203084)) * Floating components will now get an initial position even if they are not opened ([#8001](#8001)) ([78b680d](78b680d)) * **icon:** Use pixel sizes for icons ([#8009](#8009)) ([49085d5](49085d5)) * **input-date-picker, input-time-picker:** Adjust chevron scale accordingly ([#8012](#8012)) ([f894f80](f894f80)) * **input-time-zone:** Fix city translations ([#8058](#8058)) ([7df7e1f](7df7e1f)) * **list-item:** Restore tabbability when an item's disabled prop is toggled ([#8042](#8042)) ([c970603](c970603)) * **pagination:** Prevents console error when page-size is set to zero ([#8017](#8017)) ([d09d485](d09d485)) * **segmented-control-item:** Fix text color contrast ([#8036](#8036)) ([ede8c43](ede8c43)) * **stepper:** Selects next enabled stepper-item when first one is disabled ([#8004](#8004)) ([e0ed54e](e0ed54e)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @esri/calcite-design-tokens bumped from ^1.1.0-next.3 to ^1.1.0 </details> <details><summary>@esri/calcite-components-react: 1.10.0</summary> ## [1.10.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-10-30) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.10.0-next.11 to ^1.10.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: n/a
Summary
Creates icon tokens