Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent vitetest/ssr errors due to defining components on the server #7521

Merged
merged 4 commits into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/calcite-components-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
"license": "SEE LICENSE.md",
"scripts": {
"build": "rimraf dist && npm run compile",
"prebuild": "npm run patch:ssr",
"clean": "rimraf dist node_modules .turbo",
"compile": "npm run tsc",
"patch:ssr": "ts-node support/patchSSR.ts",
"tsc": "tsc"
},
"main": "./dist/index.js",
Expand Down
12 changes: 12 additions & 0 deletions packages/calcite-components-react/src/auto-define.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
const isBrowser = (): boolean =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (minor): The result of this can be computed earlier or cached. Multiple autoDefine calls run the same logic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our Teams conversation, we decided to leave this as is for now just to be very safe.

It is possible (but unlikely) that if we change isBrowser to a constant its could be cached on the server as false by an SSR framework trying to be too smart. If this were to happen and the constant didn't get reevaluated on the client, the components would never be defined.

This needs a bit more investigation.

![typeof window, typeof document, typeof location].includes("undefined") &&
[typeof process, typeof global].includes("undefined") &&
window.location === location &&
window.document === document;

export function autoDefine(component: string): () => Promise<void> | undefined {
if (isBrowser()) {
return async () => (await import(`@esri/calcite-components/dist/components/${component}.js`)).defineCustomElement();
}
return undefined;
}
51 changes: 51 additions & 0 deletions packages/calcite-components-react/support/patchSSR.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
// patch needed due to Stencil executing client side code on the server
// when using the includeImportCustomElements option
// https://stenciljs.com/docs/react#includeimportcustomelements
// https://github.com/Esri/calcite-design-system/issues/7486

const {
promises: { readFile, writeFile },
} = require("fs");
const { resolve } = require("path");

// Matches imports of defineCustomElement from calcite-component's custom-elements output target.
// Importing defineCustomElement on the server throws errors due to ESM/CJS conflicts and
// attempting to use browser APIs, which don't exist on the server.
const defineCustomElementImports = /import { defineCustomElement as defineCalcite.*(\r\n|\r|\n)/gm;

// The removed imports are replaced with autoDefine, which is a wrapper around defineCustomElement
// to make sure it's only called on the client.
const autoDefineImport = "import { autoDefine } from './auto-define';";

// Matches createReactComponent exports to add autoDefine instead of defineCustomElement.
// The regex creates capture groups for the component name and other parts of the line
// that shouldn't be replaced/removed.
const reactWrapperExports = /createReactComponent<(.*)>.*\((['|\w|-]*)(.*)(defineCalcite\w*)\)/g;

// The patched version of the createReactComponent export using the capture groups to fill in the blanks
const patchedReactWrapperExports = "createReactComponent<$1>($2$3autoDefine($2))";

// The autoDefine import is placed below this line
const reactLibImport = "import { createReactComponent } from './react-component-lib';";

(async () => {
try {
const filePath = resolve(`${__dirname}/../src/components.ts`);
const contents = await readFile(filePath, { encoding: "utf8" });

if (contents.includes(autoDefineImport)) {
console.log("SSR patch: skipping, components.ts is already patched");
return;
}

const patchedContents = contents
.replace(reactLibImport, `$&\n${autoDefineImport}`)
.replace(defineCustomElementImports, "")
.replace(reactWrapperExports, patchedReactWrapperExports);

await writeFile(filePath, patchedContents);
} catch (err) {
console.error(err);
process.exit(1);
}
})();