fix(slider): numbers remain on one line for locales with space group separators #7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
reviewed
Aug 7, 2023
| // change whitespace group characters that don't render correctly | ||
| this._group = this._actualGroup.trim().length === 0 ? " " : this._actualGroup; | ||
| // change whitespace group characters that don't render correctly to a unicode no-break space | ||
| this._group = this._actualGroup.trim().length === 0 || this._actualGroup == "\u0020" ? "\u00A0" : this._actualGroup; |
There was a problem hiding this comment.
It might be prettier to use html entities here instead of unicode. What do you think?
this._actualGroup === " " ? " " : this._actualGroup;
There was a problem hiding this comment.
Yeah I agree that's nicer for the nbsp, but I like being very explicit about what is in " ", since there are a ton of white space characters that could have been copy/pasted in there. And then I didn't want to mix and match unicode and HTML entities. But I don't feel strongly about it if you'd like me to switch. Also story incoming
…p-non-breaking * origin/main: chore(accordion-item): add more info about accordion item sync (#7473)
2 tasks
benelan
added
the
pr ready for visual snapshots
benelan
added
pr ready for visual snapshots
Merged
benelan
pushed a commit
that referenced
this pull request
Aug 8, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.5.1</summary> ## [1.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-08) ### Bug Fixes * **accordion:** Restore accordion-items working with accordion across shadow DOM ([#7466](#7466)) ([bedb5db](bedb5db)) * **action-bar, action-pad:** Add native tooltip to expand action ([#7452](#7452)) ([9673ef7](9673ef7)) * Fix SSR build error caused by browser-sniffing util ([#7461](#7461)) ([e5381fa](e5381fa)) * **flow-item:** Use a native tooltip for the back button ([#7442](#7442)) ([f38167b](f38167b)) * **input:** Fix clearable from throwing an error when value is undefined ([#7476](#7476)) ([633c2cd](633c2cd)) * **list:** Add missing drag handle locale strings ([#7462](#7462)) ([2b5463e](2b5463e)) * **panel:** Add native tooltip to close button. ([#7434](#7434)) ([70b45cf](70b45cf)) * **panel:** Allow panel content to take full height. ([#7454](#7454)) ([b6bf54f](b6bf54f)) * **panel:** Correct header and action-bar z-indexing display issues ([#7440](#7440)) ([db7eac7](db7eac7)) * **slider:** Numbers remain on one line for locales with space group separators ([#7472](#7472)) ([2747b22](2747b22)) </details> <details><summary>@esri/calcite-components-react: 1.5.1</summary> ## [1.5.1](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2023-08-08) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^1.5.1-next.4 to ^1.5.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7151
Summary
Numbers with a space group separator are breaking onto multiple lines. This replaces the space with a non-breaking space (nbsp) HTML entity.
ref: https://en.wikipedia.org/wiki/Non-breaking_space