Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: clean up global stylesheets #7377

Merged
merged 1 commit into from
Jul 25, 2023
Merged

refactor: clean up global stylesheets #7377

merged 1 commit into from
Jul 25, 2023

Conversation

driskull
Copy link
Member

Related Issue: #7325

Summary

  • Reduces root selector amount.
    • Only a single root selector now
    • animation and floating-ui CSS were spitting out their own root selectors just for CSS vars
  • Moves animation helper classes into a mixin
  • Moves reduced motion CSS into a mixin

@driskull
refactor: clean up global stylesheets
c2d2071 
- reduces root selector amount and organizes into mixins
@driskull driskull marked this pull request as ready for review July 25, 2023 17:09
@driskull driskull requested a review from a team as a code owner July 25, 2023 17:09
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jul 25, 2023
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jul 25, 2023
jcfranco
jcfranco approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✨🧹✨

@driskull driskull merged commit 18fdcc3 into main Jul 25, 2023
@driskull driskull deleted the dris0000/global-css-cleanup branch July 25, 2023 17:34
@github-actions github-actions bot added this to the 2023 July Priorities milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 July Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco