Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(popover): renames private method #7286

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

driskull
Copy link
Member

@driskull driskull commented Jul 6, 2023

Related Issue: None

Summary

  • renames private method from handlefocusTrapDisabled to handleFocusTrapDisabled

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jul 6, 2023
@driskull driskull changed the title refactor(popover): Refactor private method name. refactor(popover): renames private method Jul 6, 2023
@driskull driskull marked this pull request as ready for review July 6, 2023 16:51
@driskull driskull requested a review from a team as a code owner July 6, 2023 16:51
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🧹✨

@driskull driskull merged commit b08c58b into main Jul 6, 2023
@driskull driskull deleted the dris0000/popup-reafactor-private-method-name branch July 6, 2023 18:05
@github-actions github-actions bot added this to the 2023 July Priorities milestone Jul 6, 2023
Elijbet pushed a commit that referenced this pull request Jul 6, 2023
**Related Issue:** None

## Summary

- renames private method from `handlefocusTrapDisabled` to
`handleFocusTrapDisabled`
benelan added a commit that referenced this pull request Jul 7, 2023
* origin/main: (22 commits)
  refactor: Ensure all setFocus methods return calls to setFocus (#7287)
  chore: release next
  fix(card): ensure teardown logic is called when disconnected (#7289)
  test: stabilize tests using setFocus (#7295)
  docs: Add implementation example to `skipAnimations` util (#7293)
  docs: Add implementation example to `visualizeMouseCursor` util (#7292)
  feat: improve focus behavior in components (#7277)
  refactor(popover): renames private method (#7286)
  build(deps): Bump focus-trap from 7.4.3 to 7.5.2 (#7279)
  chore: release next
  fix(flow): Call setFocus() on back button click (#7285)
  chore: release next
  feat(flow): Adds setFocus method (#7252)
  chore: release next
  build(deps): Bump autoprefixer from 10.4.13 to 10.4.14 (#7280)
  build(deps): Bump eslint and @types/eslint (#7282)
  fix(list): fix keyboard navigation after a listItem's disabled or closed property changes (#7275)
  fix(action): correctly focus the button after rendering updates. (#7255)
  chore: release next
  fix(tab-title): add full focus outline to closable tab button in high contrast mode (#7272)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants