Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button,card,fab,inline-editable): provides context to AT users when loading #7257

Merged
merged 10 commits into from
Aug 15, 2023
Merged

fix(button,card,fab,inline-editable): provides context to AT users when loading #7257

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8767a33
fix(button): provides context when loading
anveshmekala Jun 30, 2023
f2e2a33
add aria-live attr to card and label element in loader
anveshmekala Jul 7, 2023
01d2aa8
Merge branch 'main' into anveshmekala/6534-a11y-fix-loader-live-region
anveshmekala Aug 2, 2023
70fde79
remove label and add aria-label
anveshmekala Aug 3, 2023
298f60a
add ari-live on loader element
anveshmekala Aug 11, 2023
6453f45
add aria-live for button
anveshmekala Aug 11, 2023
b52f041
refactor
anveshmekala Aug 11, 2023
4e088f7
cleanup
anveshmekala Aug 11, 2023
ce71dfa
Merge branch 'main' into anveshmekala/6534-a11y-fix-loader-live-region
anveshmekala Aug 11, 2023
b38c4ab
add tests
anveshmekala Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/calcite-components/src/components/button/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ export class Button

return (
<Tag
aria-label={getLabelText(this)}
aria-label={!this.loading ? getLabelText(this) : this.messages.loading}
aria-live="polite"
class={{
[CSS.buttonPadding]: noStartEndIcons,
[CSS.buttonPaddingShrunk]: !noStartEndIcons,
Expand Down
3 changes: 2 additions & 1 deletion packages/calcite-components/src/components/card/card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,11 @@ export class Card implements ConditionalSlotComponent, LocalizedComponent, T9nCo
render(): VNode {
const thumbnailInline = this.thumbnailPosition.startsWith("inline");
const thumbnailStart = this.thumbnailPosition.endsWith("start");

return (
<div class={{ "calcite-card-container": true, inline: thumbnailInline }}>
{this.loading ? (
<div class="calcite-card-loader-container">
<div aria-live="polite" class="calcite-card-loader-container">
<calcite-loader label={this.messages.loading} />
</div>
) : null}
Expand Down