Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(text-area): adds message to improve context when character limit exceeds. #7021

Merged
merged 4 commits into from
May 25, 2023
Merged

chore(text-area): adds message to improve context when character limit exceeds. #7021

merged 4 commits into from
May 25, 2023

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented May 24, 2023 •
edited
Loading

Related Issue: #6630

Summary

This PR will add message string in calcite-text-area to improve context of error message when character limit exceeds.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label May 24, 2023
@anveshmekala anveshmekala changed the title feat(text-area): adds context to error message when character limit exceeds. chore(text-area): adds message which provides context when character limit exceeds. May 24, 2023
@anveshmekala anveshmekala added the skip visual snapshots Pull requests that do not need visual regression testing. label May 24, 2023
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label May 24, 2023
@anveshmekala anveshmekala changed the title chore(text-area): adds message which provides context when character limit exceeds. chore(text-area): adds message to improve context when character limit exceeds. May 24, 2023
@anveshmekala anveshmekala marked this pull request as ready for review May 24, 2023 21:47
@anveshmekala anveshmekala requested a review from a team as a code owner May 24, 2023 21:47
@anveshmekala anveshmekala requested a review from geospatialem May 24, 2023 21:47
geospatialem
geospatialem approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Awesome, thanks for tackling. Looks great!

@anveshmekala anveshmekala merged commit 5c5149d into master May 25, 2023
@anveshmekala anveshmekala deleted the anveshmekala/6630-text-area-add-error-message branch May 25, 2023 17:51
@github-actions github-actions bot added this to the 1.4.1 May patch - Bugs only milestone May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem approved these changes

@jcfranco jcfranco jcfranco approved these changes

Assignees

@anveshmekala anveshmekala

Labels
chore Issues with changes that don't modify src or test files. enhancement Issues tied to a new feature or request. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
1.4.1 May patch - Bugs only
Development

Successfully merging this pull request may close these issues.
3 participants
@anveshmekala @jcfranco @geospatialem