Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tailwind to use calcite-design-tokens #6884

Merged
merged 23 commits into from
May 11, 2023

Conversation

alisonailea
Copy link
Contributor

@alisonailea alisonailea commented Apr 28, 2023

Summary

Calcite Design Tokens provides the same color variables as Calcite Colors. This should not change the styling of calcite-components or the experience for the design system consumers. This sets us up for success moving forward as Calcite Components may now align to the style tokens established by the Calcite design team.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Apr 28, 2023
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉
🎉😎🎉🎉🎉😎😎😎😎🎉😎😎😎😎😎🎉😎🎉🎉🎉😎🎉😎🎉
🎉😎🎉🎉🎉😎🎉🎉🎉🎉🎉🎉😎🎉🎉🎉😎😎🎉😎😎🎉😎🎉
🎉😎🎉🎉🎉😎🎉😎😎🎉🎉🎉😎🎉🎉🎉😎🎉😎🎉😎🎉😎🎉
🎉😎🎉🎉🎉😎🎉🎉😎🎉🎉🎉😎🎉🎉🎉😎🎉🎉🎉😎🎉🎉🎉
🎉😎😎😎🎉😎😎😎😎🎉🎉🎉😎🎉🎉🎉😎🎉🎉🎉😎🎉😎🎉
🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉🎉

Name changes suggested here might affect the imports.

@alisonailea alisonailea linked an issue May 4, 2023 that may be closed by this pull request
2 tasks
@alisonailea alisonailea marked this pull request as ready for review May 8, 2023 22:04
@alisonailea alisonailea requested a review from a team as a code owner May 8, 2023 22:04
@alisonailea alisonailea added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label May 8, 2023
@alisonailea alisonailea force-pushed the astump/feature-tailwind-tokens branch from 6b377a9 to 047b82d Compare May 9, 2023 13:35
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 9, 2023
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 9, 2023
@alisonailea alisonailea force-pushed the astump/feature-tailwind-tokens branch 2 times, most recently from 171db3b to d05acfb Compare May 10, 2023 15:54
var name falls outside normal token naming schema
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 10, 2023
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 10, 2023
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 11, 2023
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 11, 2023
@alisonailea alisonailea force-pushed the astump/feature-tailwind-tokens branch from 5df6004 to 86ac9cb Compare May 11, 2023 19:09
@alisonailea alisonailea added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels May 11, 2023
@alisonailea alisonailea merged commit 28d6e92 into master May 11, 2023
@alisonailea alisonailea deleted the astump/feature-tailwind-tokens branch May 11, 2023 20:35
@github-actions github-actions bot added this to the 2023 May Priorities milestone May 11, 2023
@eriklharper
Copy link
Contributor

So can we remove the dependency on calcite-colors as part of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design token integration
4 participants