Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat(pagination, split-button, dropdown, date-picker) action-group): add setFocus method (#6405)" #6426

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

benelan
Copy link
Member

@benelan benelan commented Feb 6, 2023

This reverts commit ceaf532.

The commit above will be reinstalled in the next few days after we release a patch.

@benelan benelan requested a review from a team as a code owner February 6, 2023 21:55
@benelan benelan force-pushed the benelan/revert-setfocus branch from 0526ac0 to 5392549 Compare February 6, 2023 21:57
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco
Copy link
Member

jcfranco commented Feb 7, 2023

For context, we're rolling this back until we're done with patching.

@benelan benelan added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 7, 2023
@benelan benelan merged commit 655f2ca into master Feb 7, 2023
@benelan benelan deleted the benelan/revert-setfocus branch February 7, 2023 18:25
benelan added a commit that referenced this pull request Feb 8, 2023
…c-rulez

* origin/master:
  docs: update component READMEs (#6352)
  ci(next): fix commit message (#6425)
  fix(vite): resolve lazying loading error in dist build (#6436)
  docs(changelog): remove reverted feature (#6435)
  revert: "feat(pagination, split-button, dropdown, date-picker) action-group): add setFocus method (#6405)" (#6426)
  1.1.0-next.2
  docs(segmented-control): update event description for calciteSegmentedControlChange (#6428)
  fix(tree-item): reverses regression to bring back focus when navigating with keyboard (#6424)
  fix(icon): fix icon normalization to handle x-times-named icons (#6422)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants