-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump versions #2257
Conversation
@jcfranco for some reason, this bump caused all the stories to disappear from storybook. Do you know how stories are added? Is there some config we need to update? |
@driskull Is there an error of some sort showing up? I don't see why they would disappear from this PR. There are a couple of dependencies that went through a major version bump, so maybe those could be causing issues. If that still fails, testing w/o bumping the storybook deps could shed some light. |
It seems the typescript bump to 4.3.2 is causing the problem. Maybe something here: https://devblogs.microsoft.com/typescript/announcing-typescript-4-3/#breaking-changes I'll skip that bump for now. |
Sounds good. Thanks for looking at this! Can you add |
I found this on storybook issues: storybookjs/storybook#15067 Seems like a potential solution is to do this:
Would we like to do this instead? |
Let's try if there's no fix by the time Stencil bumps to 4.3.2. |
Tried that fix and it didn't work. |
Can someone approve the bump? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
build(deps): bump versions