Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump versions #2257

Merged
merged 5 commits into from
Jun 3, 2021
Merged

build(deps): bump versions #2257

merged 5 commits into from
Jun 3, 2021

Conversation

driskull
Copy link
Member

@driskull driskull commented Jun 3, 2021

build(deps): bump versions

@driskull driskull requested a review from a team as a code owner June 3, 2021 19:19
@driskull
Copy link
Member Author

driskull commented Jun 3, 2021

@jcfranco for some reason, this bump caused all the stories to disappear from storybook. Do you know how stories are added? Is there some config we need to update?

@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. help wanted Issues that the core team needs help with in a sprint. labels Jun 3, 2021
@jcfranco
Copy link
Member

jcfranco commented Jun 3, 2021

@driskull Is there an error of some sort showing up? I don't see why they would disappear from this PR. There are a couple of dependencies that went through a major version bump, so maybe those could be causing issues. If that still fails, testing w/o bumping the storybook deps could shed some light.

@driskull
Copy link
Member Author

driskull commented Jun 3, 2021

It seems the typescript bump to 4.3.2 is causing the problem.

Maybe something here: https://devblogs.microsoft.com/typescript/announcing-typescript-4-3/#breaking-changes

I'll skip that bump for now.

@jcfranco
Copy link
Member

jcfranco commented Jun 3, 2021

Sounds good. Thanks for looking at this! Can you add typescript as an exception to the deps:update script? It should probably be manually updated along w/ Stencil's other dependencies.

@driskull
Copy link
Member Author

driskull commented Jun 3, 2021

I found this on storybook issues: storybookjs/storybook#15067

Seems like a potential solution is to do this:
storybookjs/storybook#15067 (comment)

typescript: {
    reactDocgen: 'none',
}

Would we like to do this instead?

@jcfranco
Copy link
Member

jcfranco commented Jun 3, 2021

Let's try if there's no fix by the time Stencil bumps to 4.3.2.

@driskull
Copy link
Member Author

driskull commented Jun 3, 2021

Tried that fix and it didn't work.

@driskull
Copy link
Member Author

driskull commented Jun 3, 2021

Can someone approve the bump?

@jcfranco jcfranco added this to the Sprint 5/24 – 6/7 milestone Jun 3, 2021
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@driskull driskull merged commit c3fa713 into master Jun 3, 2021
@driskull driskull deleted the dris0000/bump branch June 3, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. help wanted Issues that the core team needs help with in a sprint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants