feat(text-area): add support for minLength
#10970
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
requested changes
Dec 6, 2024
packages/calcite-components/src/components/text-area/assets/t9n/messages.json
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/text-area/resources.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/text-area/text-area.tsx
Outdated
Show resolved
Hide resolved
Elijbet
commented
Dec 7, 2024
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "invalid": "Invalid", | |||
| "tooLong": "The current character length is {currentLength}, which exceeds the maximum character length of {maxLength}." | |||
| "tooLong": "The current character length is {currentLength}, which exceeds the maximum character length of {maxLength}.", | |||
| "tooShort": "The current character length is {currentLength}, which is less than the minimum character length of {minLength}." | |||
There was a problem hiding this comment.
@geospatialem could you review the string wording?
There was a problem hiding this comment.
Awesome, @Elijbet - wording LGTM! 🚀
jcfranco
changed the title
minlength to text-areaminLength
jcfranco
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Had a few comments, but this looks great, @Elijbet!
Can you also add a screenshot test? We can tweak the Exceeding Max Length Test Only story to include both min and max tests (along with proper rename).
| ariaLabel={getLabelText(this)} | ||
| autofocus={this.el.autofocus} | ||
| class={{ | ||
| [CSS.textArea]: true, | ||
| [CSS.readOnly]: this.readOnly, | ||
| [CSS.textAreaInvalid]: this.isCharacterLimitExceeded(), | ||
| [CSS.textAreaInvalid]: | ||
| this.isCharacterOverMaxLimit() || this.isCharacterUnderMinLimit(), |
There was a problem hiding this comment.
Let's DRY this up by storing and reusing the results of isCharacterOverMaxLimit() and isCharacterUnderMinLimit() within this render method.
packages/calcite-components/src/components/text-area/text-area.tsx
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/text-area/text-area.e2e.ts
Outdated
Show resolved
Hide resolved
… replacing long and short messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8626
Summary
Add support for
minlengthtotext-area.