refactor: handle stencil vs lumina boolean reflection differences #10662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
benelan
added
the
pr ready for visual snapshots
benelan
added
the
skip visual snapshots
github-actions
bot
added this to the 2024-11-19 - 3.0.0 Nov Breaking Change Milestone milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10482
Summary
Resolve the
validationIconissue brought up in #10509 (comment)The only properties affected by the change in how boolean properties are reflected are
icon,validationIcon, anddownload. This PR fixes the utils that caused issues withiconandvalidationIcon. Thedownloadproperty seems to already be correct, for example:calcite-design-system/packages/calcite-components/src/components/link/link.tsx
Line 178 in 2531999