Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color picker: component enhancements #9624

Closed
2 of 6 tasks
aPreciado88 opened this issue Jun 17, 2024 · 2 comments
Closed
2 of 6 tasks

Color picker: component enhancements #9624

aPreciado88 opened this issue Jun 17, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2024-07-31 - Jul ...

Comments

@aPreciado88
Copy link
Contributor

aPreciado88 commented Jun 17, 2024 •
edited
Loading

Check existing issues

Description

-Auto select values when clicking on input fields. This should apply to all inputs in color-picker.
-Improved value commit:

  1. The hex input should auto-commit a valid 6-char (or 8-char if alpha-channel is enabled).
  2. A 3-char (or 4-char with alpha-channel) shorthand value would commit onBlur.
  3. Channel inputs should auto-commit valid values. If the user deletes the value completely, there would be no change. If left blank, the original value should be restored onBlur.

-onBlur should include clicking anywhere outside the input. As of v1.8.0, the user must click outside the entire component.

Which Component

color-picker

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

Figma file
@aPreciado88 aPreciado88 added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. labels Jun 17, 2024
@aPreciado88 aPreciado88 added this to the 2024-07-30 - Jul Release milestone Jun 17, 2024
@aPreciado88 aPreciado88 self-assigned this Jun 17, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 17, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. estimate - 5 A few days of work, definitely requires updates to tests. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 17, 2024
@aPreciado88 aPreciado88 mentioned this issue Jun 26, 2024
Merged
aPreciado88 added a commit that referenced this issue Jul 19, 2024
@aPreciado88
feat(color-picker, color-picker-hex-input): Add input auto commit, bl…
281a869 
…ur and auto select enhancements. (#9701)

**Related Issue:**
[#9624](#9624)

## Summary

Updates `color-picker` and `color-picker-hex-input` to:

-Auto select values when clicking on input fields. This applies to all
inputs.
-Auto commit a valid 6-char (or 8-char if alpha-channel is enabled).
-Commit a 3-char (or 4-char with alpha-channel) shorthand value onBlur.
-Auto commit channel inputs. If the user deletes the value completely,
there will be no change. If left blank, the original value will be
restored onBlur.
-Increase/decrease channel input value, when the input is cleared and
Arrow-up or Arrow-down are pressed.
-Blur focused input when clicking anywhere within the component, this
applies to all input fields.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 19, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Jul 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 22, 2024

🍡Verified on 2.11.0-next.15

@DitwanP DitwanP closed this as completed Jul 22, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 22, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@aPreciado88 @github-actions
feat(color-picker, color-picker-hex-input): Add input auto commit, bl…
b2be625 
…ur and auto select enhancements. (#9701)

**Related Issue:**
[#9624](#9624)

## Summary

Updates `color-picker` and `color-picker-hex-input` to:

-Auto select values when clicking on input fields. This applies to all
inputs.
-Auto commit a valid 6-char (or 8-char if alpha-channel is enabled).
-Commit a 3-char (or 4-char with alpha-channel) shorthand value onBlur.
-Auto commit channel inputs. If the user deletes the value completely,
there will be no change. If left blank, the original value will be
restored onBlur.
-Increase/decrease channel input value, when the input is cleared and
Arrow-up or Arrow-down are pressed.
-Blur focused input when clicking anywhere within the component, this
applies to all input fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88