-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcite-modal is being blocked by another element, but only in Safari #9416
Comments
@MikeTschudi We noticed a similar issue in crowdsource-reporter today. I found a workaround for this by overriding calcite-modal's position property to be fixed and it works as I expect it to.
|
@bcree11, very nice--thank you! Works in crowdsource-manager as well, which was the original issue. |
As long as it all still works when the modal is in the Modals slot, in those cases where we want to constrain it to the Shell, it does have to be absolute I believe. |
@macandcheese Awesome. I think we have a path forward then. The slotted modal & alert screenshot test should cover it, right? |
…pping content in certain layouts (#9545) **Related Issue:** #9416 ## Summary This restores `modal`'s host positioning to `fixed` to avoid a [Safari bug](https://bugs.webkit.org/show_bug.cgi?id=160953) that causes content to be clipped. **Note**: screenshot test was not added for this scenario since our testing environment uses Chrome. BREAKING CHANGE: This should not require changes, but we are including this in the breaking change release due to the different modal configurations that could be impacted by the default `position` change.
Installed and assigned for verification. |
…pping content in certain layouts (#9545) **Related Issue:** #9416 ## Summary This restores `modal`'s host positioning to `fixed` to avoid a [Safari bug](https://bugs.webkit.org/show_bug.cgi?id=160953) that causes content to be clipped. **Note**: screenshot test was not added for this scenario since our testing environment uses Chrome. BREAKING CHANGE: This should not require changes, but we are including this in the breaking change release due to the different modal configurations that could be impacted by the default `position` change.
🍡 Verified on |
Check existing issues
Actual Behavior
We have an instant app that displays a map of features in a left panel and a table of features in a right panel. If one selects multiple features and clicks the "Delete" button, we display a calcite-modal as a double-check before performing the deletion. All is good on Windows (Chrome, Edge, Firefox) and on Mac Chrome. On Mac Safari, however, the calcite-modal is partially blocked.
Here is what the app modal looks like in all but Safari:
And here is what it looks like in Safari:
The calcite-modal is triggered by a component that resides in an action-bar:
I can't tell if this is a bug in our app or in calcite: I am having trouble isolating the cause.
Expected Behavior
I expected the modal to be on top, as it is outside of Safari
Reproduction Sample
https://codepen.io/miketschudi/pen/GRaZwEd
Reproduction Steps
In the CodePen, click on the Delete button to open the modal.
The modal is nested because we're using nested components; the modal is in the delete-button component; all other non-calcite-components have been replaced by divs.
Reproduction Version
2.8.3
Relevant Info
Regression?
went back to 1.0.3 and still see issue
Priority impact
impact - p3 - not time sensitive
Impact
Affects Safari users of the Manager Instant App; workaround is to delete items one-by-one via a different Delete button.
Calcite package
Esri team
ArcGIS Solutions
The text was updated successfully, but these errors were encountered: