Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[List Item]: update single-select icons #9174

Closed
5 of 9 tasks
ashetland opened this issue Apr 23, 2024 · 8 comments
Closed
5 of 9 tasks

[List Item]: update single-select icons #9174

ashetland opened this issue Apr 23, 2024 · 8 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2024-11-26 - 3.0....

Comments

@ashetland
Copy link
Contributor

ashetland commented Apr 23, 2024 •
edited by geospatialem
Loading

Check existing issues

Description

Update single-select icons to align with Table. List was previously updated to match Dropdown, but the small dot is less ideal for content-rich settings where the selection state needs to be more prominent. Small dots are also commonly used to indicate activity.

While not a breaking change by itself, this should be paired with #7100 and #9173.

Acceptance Criteria

For selection-appearance="icon" and selection-mode="single"`:

image

Relevant Info

No response

Which Component

List
List Item

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 23, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 23, 2024
@ashetland
Copy link
Contributor Author

cc @driskull

@ashetland ashetland mentioned this issue Apr 26, 2024
Closed
7 tasks
@geospatialem geospatialem added breaking change Issues and pull requests with code changes that are not backwards compatible. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 26, 2024
@macandcheese macandcheese added the c-list Issues that pertain to the calcite-list component label May 1, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Jun 18, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jun 18, 2024
@jcfranco jcfranco added visual changes Issues with visual changes that are added for consistency, but are not backwards compatible and removed breaking change Issues and pull requests with code changes that are not backwards compatible. labels Aug 2, 2024
@ashetland ashetland mentioned this issue Oct 22, 2024
Open
9 tasks
@ashetland ashetland changed the title [List]: update single-select icons [List Item]: update single-select icons Oct 23, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Oct 23, 2024
@aPreciado88 aPreciado88 self-assigned this Nov 1, 2024
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 1, 2024
@ashetland ashetland added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Nov 18, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 18, 2024
@ashetland ashetland added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels Nov 18, 2024
@jcfranco jcfranco assigned jcfranco and unassigned aPreciado88 Nov 22, 2024
@jcfranco jcfranco mentioned this issue Nov 24, 2024
Merged
@jcfranco
Copy link
Member

  • 24px icons for scale="l"

@ashetland @geospatialem list doesn't currently support scale, so we'll need to tackle this after #7100 lands.

@jcfranco jcfranco mentioned this issue Nov 24, 2024
Closed
@jcfranco
Copy link
Member

tackle this after #7100 lands.

I created a draft PR that just needs scale to be set in place. cc @eriklharper

@jcfranco
Copy link
Member

  • 24px icons for scale="l"

@ashetland Can you clarify if this is meant for all selection modes or specifically for single-select?

@ashetland
Copy link
Contributor Author

Yes, all selection modes.

@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 25, 2024
jcfranco added a commit that referenced this issue Nov 25, 2024
@jcfranco
feat(list-item): update single-select icons (#10858)
d50aaa4 
**Related Issue:** #9174

## Summary

Updates single-select icons according to the updated spec:

* `circle` for unselected (using `color.border.input`)
* `circle-inset-large` for selected
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 25, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 25, 2024
@geospatialem
Copy link
Member

Verified on 3.0.0-next.28, note that the 24px icons will land in #7100, re: #9174 (comment):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. c-list Issues that pertain to the calcite-list component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality p4 - not time sensitive User set priority status of p4 - not time sensitive ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
6 participants
@jcfranco @macandcheese @geospatialem @DitwanP @ashetland @aPreciado88