Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calcite-action-bar: tooltip causing wrong width for action bar #8386

Closed
2 of 6 tasks
AdelheidF opened this issue Dec 8, 2023 · 8 comments
Closed
2 of 6 tasks

calcite-action-bar: tooltip causing wrong width for action bar #8386

AdelheidF opened this issue Dec 8, 2023 · 8 comments
Assignees
@driskull
Labels
2 - in development Issues that are actively being worked on. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-01-17 - Jan ...

Comments

@AdelheidF
Copy link

AdelheidF commented Dec 8, 2023 •
edited
Loading

Check existing issues

Actual Behavior

Before and after look of right action bar when adding calcite-blocks in flow-item panel.
image image

Contact me for a test case.

cc @driskull

Expected Behavior

Action bar width doesn't change.

Reproduction Sample

N/A

Reproduction Steps

Open MV and notice 2 action bars, right and left, in the viewer. Click on popup config action to open that panel. Then click 'add content' and 'Fields list'. Notice that the action bar on the left disappears and there is blank space at the right of the MV.
If you hover over the expand icon of the action bar it corrects itself.

Reproduction Version

2.0.0

Relevant Info

No response

Regression?

Yes

Priority impact

p0 - emergency

Impact

Very visible in MV

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer
@AdelheidF AdelheidF added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 8, 2023
@github-actions github-actions bot added impact - p0 - emergency User set priority impact status of p0 - emergency ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. calcite-components Issues specific to the @esri/calcite-components package. labels Dec 8, 2023
@driskull
Copy link
Member

@AdelheidF can you try creating a reproduction of this to help with verification?

@AdelheidF
Copy link
Author

We can use a local MV build using a calcite next version to verify this. I don't even know what's causing this issue to create a simple test case.

cc @kevindoshier

@AdelheidF
Copy link
Author

Here is an attempt, but adding a block or re-ordering blocks doesn't cause it in this codepen.
https://codepen.io/afreitag/pen/JjxVMXQ

@driskull driskull mentioned this issue Dec 12, 2023
Merged
driskull added a commit that referenced this issue Dec 13, 2023
@driskull
fix(floating-ui): improve floating element performance (#8409)
4d8cfb8 
**Related Issue:** #7979 #8214 #8386 #8419 #5697

## Summary

- reverts #8001
  - Keeps doc updates 
- reverts partially #8230
- Keeps drag classes that are setting `overflow:hidden` when a drag is
occurring.
- Keeps roundByDPR floating-ui fix.
https://floating-ui.com/docs/misc#subpixel-and-accelerated-positioning
- Hides overflow for `calcite-sortable--chosen` class
- Only sets `top` and `left` on floating element once positioned. **This
fixes native drag and drop issue**
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@AdelheidF
Copy link
Author

not fixed with 2.1.0-next.8

@driskull driskull assigned driskull and unassigned geospatialem and DitwanP Dec 13, 2023
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 13, 2023
@driskull driskull added this to the 2023 December Priorities milestone Dec 13, 2023
@driskull
Copy link
Member

I'll take another look. 👀

@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Dec 13, 2023
@driskull driskull removed the impact - p0 - emergency User set priority impact status of p0 - emergency label Dec 14, 2023
@driskull driskull added p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels Dec 14, 2023
@driskull
Copy link
Member

I can't reproduce this one. ok to close @AdelheidF?

@AdelheidF
Copy link
Author

We installed a workaround using overlayPositioning="fixed" on calcite-action-group and calcite-tooltip. With that we don't see the issue anymore.

We can re-open if someone else runs into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@driskull driskull

Labels
2 - in development Issues that are actively being worked on. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

No branches or pull requests
5 participants
@driskull @geospatialem @AdelheidF @DitwanP @brittneytewks